Enhancement of the knapsack algorithm #9266 #9682
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BinaryTree class has been created with the root node as its only argument. The utility functions have been modified to be methods of the BinaryTree class. The display, depth_of_tree, and is_full_binary_tree functions now take self as their first argument. The main function has been modified to create a BinaryTree object and call its methods instead of calling the utility functions directly.
for more information, see https://pre-commit.ci
The BinaryTree class has been created with the root node as its only argument. The utility functions have been modified to be methods of the BinaryTree class. The display, depth_of_tree, and is_full_binary_tree functions now take self as their first argument. The main function has been modified to create a BinaryTree object and call its methods instead of calling the utility functions directly.
I have done the following changes: 1)Added the missing f parameter to the mf_knapsack function. 2)Fixed the indexing issue in the knapsack function. 3)Added type hints to function parameters. 4)Fixed the indexing issue in the knapsack_with_example_solution function. 5)Added type hints to the return type of the knapsack_with_example_solution function. 6)Fixed the indexing issue in the _construct_solution function. 7)Added type hints to the parameters of the _construct_solution function. 8)Passed the f parameter to the mf_knapsack function in the __main__ block.
for more information, see https://pre-commit.ci
|
@tianyizheng02 Any maintainer please review and close #9266 |
|
Please DO NOT remove tests |
algorithms-keeper
bot
added
awaiting reviews
|
Closing tests_are_failing PRs to prepare for Hacktoberfest 2024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
I have done the following changes:
1)Added the missing f parameter to the mf_knapsack function.
2)Fixed the indexing issue in the knapsack function.
3)Added type hints to function parameters.
4)Fixed the indexing issue in the knapsack_with_example_solution function.
5)Added type hints to the return type of the knapsack_with_example_solution function.
6)Fixed the indexing issue in the _construct_solution function.
7)Added type hints to the parameters of the _construct_solution function.
8)Passed the f parameter to the mf_knapsack function in the main block.
Checklist: